gyfora commented on a change in pull request #8410: [FLINK-11159] Allow
configuration whether to fall back to savepoints for restore
URL: https://github.com/apache/flink/pull/8410#discussion_r282908128
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1093,6 +1098,23 @@ public boolean restoreLatestCheckpointedState(
}
}
+ CompletedCheckpoint candidate = null;
+ if (isPerferCheckpointForRecovery &&
completedCheckpointStore.getAllCheckpoints().size() > 1) {
Review comment:
It feels like this part basically reimplements the getLatestCheckpoint()
logic of the completed checkpoint store. Maybe instead of having this hear the
getLatestCheckpoint( ) could take the preferCheckpoints boolean parameter for
better encapsulation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
