azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r282884777
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -348,19 +352,26 @@ private void
handleStartTaskExecutorServicesException(Exception e) throws Except
resourceManagerHeartbeatManager.stop();
try {
- stopTaskExecutorServices();
+ CompletableFuture<Void> onStopFuture =
stopTaskExecutorServices(failingTaskFutures);
+ log.info("Stopped TaskExecutor {}.", getAddress());
+ return onStopFuture;
Review comment:
If `throwable != null` at this point of `return onStopFuture;`, we ignore
`throwable != null` which was not the case previously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
