xuefuz commented on a change in pull request #8390: [FLINK-12469][table] Clean
up catalog API on default/current database
URL: https://github.com/apache/flink/pull/8390#discussion_r282886973
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -65,9 +64,15 @@
private final Map<ObjectPath, Map<CatalogPartitionSpec,
CatalogColumnStatistics>> partitionColumnStats;
public GenericInMemoryCatalog(String name) {
+ this(name, DEFAULT_DB);
+ }
+
+ public GenericInMemoryCatalog(String name, String defaultDatabase) {
Review comment:
Hi @dawidwys Thanks for your review. To clarify, do you mean we don't want
user to set a default database other than DEFAULT_DB? I'm fine with this
because there is the only one it has when the catalog is initialized.
Even for GenericInMemoryCatlog, it confirms the catalog API, allowing user
to create different databases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
