yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r282451226
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -115,6 +115,8 @@
private volatile ScheduledFuture<?> cancellerHandle;
+ private final CheckpointFailureManager failureManager;
Review comment:
Yes, introducing `CheckpointFailureManager` into `PendingCheckpoint` is to
avoid scattering calls of `failureManager.handleCheckpointException(exception)`
over the coordinator. I accept this suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
