godfreyhe commented on a change in pull request #8288: [FLINK-12345]
[table-planner-blink] Add support for generating optimized logical plan for
stream window aggregate
URL: https://github.com/apache/flink/pull/8288#discussion_r281495472
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/sql/ProctimeSqlFunction.java
##########
@@ -37,16 +39,24 @@ public ProctimeSqlFunction() {
super(
"PROCTIME",
SqlKind.OTHER_FUNCTION,
- ReturnTypes.explicit(new ProctimeRelProtoDataType()),
- null,
- OperandTypes.NILADIC,
- SqlFunctionCategory.TIMEDATE);
+
ReturnTypes.cascade(ReturnTypes.explicit(SqlTypeName.TIMESTAMP),
SqlTypeTransforms.TO_NULLABLE),
Review comment:
I didn't notice `ProctimeMaterializeSqlFunction`'s existence before, i will
revert the changes in `ProctimeSqlFunction`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
