sunjincheng121 commented on a change in pull request #8347:
[FLINK-12326][python] Add basic test framework for python api
URL: https://github.com/apache/flink/pull/8347#discussion_r281438679
##########
File path: flink-python/pyflink/find_flink_home.py
##########
@@ -41,5 +41,19 @@ def _find_flink_home():
sys.exit(-1)
+def _find_flink_source_root():
+ """
+ Find the flink source root directory.
+ """
+ try:
+ flink_source_root_dir =
os.path.abspath(os.path.dirname(os.path.abspath(__file__)) + "/../../")
+ if os.path.isdir(flink_source_root_dir + "/build-target"):
Review comment:
I think it's better to remove this check. What doyou think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
