xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r281262868
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/stats/CatalogColumnStatisticsDataLong.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.stats; + +import java.util.HashMap; +import java.util.Map; + +/** + * Column statistics value of long type. + */ +public class CatalogColumnStatisticsDataLong extends CatalogColumnStatisticsDataBase { + /** + * mim value. + */ + private final long min; + + /** + * max value. + */ + private final long max; + + /** + * number of distinct values. + */ + private final long ndv; Review comment: Yeah. Hive uses double stats for both "double" and "float". Theoretically, ndvs for double might not be accurate, but from statistical point view, the value is still there. It's just that it cannot be used to answer queries such as select count(distinct). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
