bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive]
Support table related operations in GenericHiveMetastoreCatalog
URL: https://github.com/apache/flink/pull/8329#discussion_r280256225
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -41,28 +41,28 @@
private final List<String> partitionKeys;
// Properties of the table
private final Map<String, String> properties;
- // Comment of the table
- private String comment = "This is a generic catalog table.";
+ // Description of the table
+ private String description = "This is a generic catalog table.";
Review comment:
I agree. To add on, I also doubt the necessity to have a predefined
description and a predefined detailed description.
Nevertheless, I think we'd better leave them to a different PR. I'll revert
this part to make this PR focus on what it intends to accomplish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
