xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support
table related operations in GenericHiveMetastoreCatalog
URL: https://github.com/apache/flink/pull/8329#discussion_r280248483
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericCatalogTable.java
##########
@@ -41,28 +41,28 @@
private final List<String> partitionKeys;
// Properties of the table
private final Map<String, String> properties;
- // Comment of the table
- private String comment = "This is a generic catalog table.";
+ // Description of the table
+ private String description = "This is a generic catalog table.";
Review comment:
since you're changing this part, I'm wondering if it makes sense to move the
comment to properties, as that's what Hive does. Doing this might simply things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
