[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

[GitBox]

lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application 
can't stop when flink job failed in per-job yarn cluste mode
URL: https://github.com/apache/flink/pull/8254#issuecomment-487895820
 
 
   hi @tillrohrmann, yes, at least we need to record the exception record, so I 
log the exception and re-throw it again.
   ```
   protected void jobReachedGloballyTerminalState(ArchivedExecutionGraph 
archivedExecutionGraph) {
   
       try {
           super.jobReachedGloballyTerminalState(archivedExecutionGraph);
       } catch (Exception e) {
           log.error("jobReachedGloballyTerminalState exception", e);
           throw e;
       } finally {
           if (executionMode == ClusterEntrypoint.ExecutionMode.DETACHED) {
               // shut down since we don't have to wait for the execution 
result retrieval
               
jobTerminationFuture.complete(ApplicationStatus.fromJobStatus(archivedExecutionGraph.getState()));
           }
       }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services