KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r279277736
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/CalcCodeGenerator.scala ########## @@ -69,6 +71,42 @@ object CalcCodeGenerator { new OneInputOperatorWrapper(genOperator) } + private[flink] def generateFunction[T <: Function]( Review comment: why don't adding this to `FunctionCodeGenerator`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services