StefanRRichter commented on a change in pull request #7571: [FLINK-10724] 
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r278911759
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -561,7 +566,7 @@ public CheckpointTriggerResult triggerCheckpoint(
                                                job,
                                                numUnsuccessful,
                                                t);
-                               return new 
CheckpointTriggerResult(CheckpointDeclineReason.EXCEPTION);
+                               throw new 
CheckpointException(CheckpointFailureReason.EXCEPTION);
 
 Review comment:
   I think you could pass the cause exception `t` into the constructor of the 
`CheckpointException`. This can help with debugging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to