bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278267230
########## File path: flink-connectors/flink-connector-hive/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,41 @@ +flink-connector-hive +Copyright 2014-2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- org.apache.hadoop:hadoop-common:2.7.2 Review comment: Hive metastore 2.x depends on `org.apache.hadoop.crypto` package in hadoop-common (hive-metastore 2.3.4 -> hadoop-common 2.7.2, hive-metastore 2.1.1 -> hadoop-common 2.6.1), and that package is only available since hadoop 2.6. My main concern is that, according to https://flink.apache.org/downloads.html, we still support hadoop 2.4. If users provide that, then hive-metastore won't be able to run. I actually wonder if Flink 1.9.0 is a good time to cut off support for hadoop 2.4? If so, I think it'll be a big help and we don't need to bundle hadoop-common anymore. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
