Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/1096#issuecomment-138277939
  
    Yes, I don't see any advantage in having this overload. I would also change 
`add(long value)` and `add(int value)` into `add(Long value)` and `add(Integer 
value)` for consistency (I actually prefer primitive types, too; however, for 
this case class types seems to be more appropriate because the inherited 
methods use `Double` as parameter and as return type in `getLocalValue()`).
    
     But you should wait for @StephanEwen feedback before chancing anything. I 
am new to accumulators...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to