zhijiangW edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#issuecomment-484820243 Thanks for the reviews @azagrebin ! If I understand correctly, the total IO related metrics could be divided into two groups. One group is general and suitable for all `ShuffleService` implementations such as current `numBytesIn/Out`, `numRecordsIn/Out` which would be still created in current `TaskIOMetrics`. Another group is special for current `NetworkEnvironment` implementation. I introduce the new `InputChannelMetrics` for wrapping the local/remote channel related metrics which would be created in network internals during `ShuffleService#createInputGates` future. Considering compatibility with current behavior, the `numBytesInTotal` metric is handled by `SingleInputGate` temporarily. In the following PR for [FLINK-12201](https://issues.apache.org/jira/browse/FLINK-12201), this metric would be handled by `InputGateWithMetrics` in task.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
