xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add 
function related catalog APIs
URL: https://github.com/apache/flink/pull/8212#discussion_r277953303
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java
 ##########
 @@ -562,6 +568,158 @@ public void testRenameView() throws Exception {
                catalog.dropTable(viewPath2, false);
        }
 
+       // ------ functions ------
+
+       @Test
+       public void testCreateFunction() throws Exception {
+               catalog.createDatabase(db1, createDb(), false);
+
+               assertFalse(catalog.functionExists(path1));
+
+               catalog.createFunction(path1, createFunction(), false);
+
+               assertTrue(catalog.functionExists(path1));
+
+               catalog.dropFunction(path1, false);
 
 Review comment:
   I think having it here is okay so that it doesn't pass the side-effect to 
other test cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to