walterddr commented on a change in pull request #8234: [FLINK-12288]
[table-planner-blink] Bump Calcite dependency to 1.19.0 in blink planner
URL: https://github.com/apache/flink/pull/8234#discussion_r277912372
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/plan/batch/sql/CalcTest.xml
##########
@@ -85,7 +85,7 @@ LogicalProject(a=[$0], b=[$1], c=[$2], d=[$3])
</Resource>
<Resource name="planAfter">
<![CDATA[
-Calc(select=[a, CAST(1984-07-12) AS b, CAST(14:34:24) AS c, CAST(1984-07-12
14:34:24) AS d], where=[AND(=(b, 1984-07-12), =(c, 14:34:24), =(d, 1984-07-12
14:34:24))])
+Calc(select=[a, CAST(1984-07-12) AS b, CAST(14:34:24) AS c, CAST(1984-07-12
14:34:24:TIMESTAMP(3)) AS d], where=[AND(=(b, 1984-07-12), =(c, 14:34:24), =(d,
1984-07-12 14:34:24:TIMESTAMP(3)))])
Review comment:
I observe something weird upon comparing calcite 1.16/17/18/19 on this (not
yet on 19) seems like the timestamp type representation is bouncing here and
there a lot. do you think this is solely just the serialization (print string)
changes or actually there's some changes to the underlying type? as this might
be problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
