xuefuz commented on a change in pull request #8222: [FLINK-11518] [table] Add
partition related catalog APIs and implement them in GenericInMemoryCatalog
URL: https://github.com/apache/flink/pull/8222#discussion_r277786569
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java
##########
@@ -29,4 +32,15 @@
* @return table statistics
*/
TableStats getStatistics();
+
+ /**
+ * Check if the table is partitioend or not.
+ */
+ boolean isPartitioned();
+
+ /**
+ * Get the partition keys of the table. This will be an empty set if
the table is not partitioned.
+ * @return partition keys of the table.
+ */
Review comment:
Above javadoc says an empty set is returned if table is not partitioned
while the method signature throws a TableNotPartitioned exception. This doesn't
seem consistent. In my opinion, we shouldn't throw an exception. (But if we do,
we also need to include it in the javadoc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
