JingsongLi commented on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#issuecomment-483933526 > The changes to lpad and rpad looks good to me. > > Btw, I would suggest to move tests in `BuiltInFunctionsITCase`, `DateFunctionsITCase`, `StringITCase` to unit tests under `org.apache.flink.table.expressions.utils`. Because integrated test will cost much more time than unit tests, and they can be covered by expression unit tests. I think these ITCases are not just Expression tests, they are different from Expression tests in that they integrate CodeGen of sort of exprs into an Operator to achieve some different results. Now with AbstractTestBase, tests are at the millisecond level and should not be slow.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
