zhijiangW edited a comment on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483745947 I would double check whether the `TaskManagerMetricGroup` should be closed in `TaskManagerServices` like other components, and atm it is closed by `TaskExecutor` to keep the same behavior during refactor. Then I would refactor the related tests in the following commit to avoid calling `NetworkEnvironment#getNetworkBufferPool`, then we could remove this getter completely.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
