StefanRRichter commented on a change in pull request #7571: [FLINK-10724]
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r275792745
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -405,54 +404,22 @@ public void addMasterState(MasterState state) {
//
------------------------------------------------------------------------
/**
- * Aborts a checkpoint because it expired (took too long).
+ * Aborts a checkpoint with abort reason and cause.
*/
- public void abortExpired() {
+ public void abort(CheckpointAbortReason reason, Throwable cause) {
Review comment:
In many cases, this method is called with `cause == null`, why not overload
the method and have a second variant that only takes a `reason` and we avoid
the confusing null values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
