hequn8128 commented on a change in pull request #8162: [FLINK-12174][table]
Introduce FlinkAggregateExtractProjectRule and remove extractFieldReferences
URL: https://github.com/apache/flink/pull/8162#discussion_r275801911
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/batch/sql/SingleRowJoinTest.scala
##########
@@ -187,7 +187,7 @@ class SingleRowJoinTest extends TableTestBase {
unaryNode(
"DataSetCalc",
batchTableNode(1),
- term("select", "0 AS $f0")),
+ term("select", "")),
Review comment:
Year, this is right. Besides, this would bring performance improvement, as
select() is Row(0) while select(0 as xx) is Row(1). The data will be smaller.
I will add the IT case in the coming update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
