Myasuka commented on a change in pull request #7813: [FLINK-10712] Support to
restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7813#discussion_r275454355
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
##########
@@ -206,13 +228,15 @@ private void restart(long globalModVersionOfFailover) {
try {
if (transitionState(JobStatus.CREATED,
JobStatus.RUNNING)) {
// if we have checkpointed state, reload it
into the executions
- //TODO: checkpoint support restore part
ExecutionVertex cp
- /**
if (executionGraph.getCheckpointCoordinator()
!= null) {
+ // we restart the checkpoint scheduler
for
+ // i) enable new checkpoint could be
triggered without waiting for last checkpoint expired.
+ // ii) ensure the EXACTLY_ONCE
semantics if needed.
+
executionGraph.getCheckpointCoordinator().cancelPendingCheckpoints();
+
executionGraph.getCheckpointCoordinator().restoreLatestCheckpointedState(
Review comment:
Sounds reasonable, and can't believe this JIRA was created almost two years
ago!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
