wuchong commented on a change in pull request #8109:
[FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to
StreamTransformation
URL: https://github.com/apache/flink/pull/8109#discussion_r275105047
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/runtime/utils/StreamingTestBase.scala
##########
@@ -53,4 +55,8 @@ class StreamingTestBase extends AbstractTestBase {
this.tEnv = StreamTableEnvironment.create(env)
}
+ def writeToSink(table: Table, sink: TableSink[_]): Unit = {
Review comment:
I think we should avoid to use `writeToSink(table, sink)` in IT case. The
logical in `writeToSink` should be placed in TableEnvironment, not a test util
or test base.
Please Use `tEnv.writeToSink(table, sink)` or `Table.insertInto` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
