StefanRRichter commented on a change in pull request #7571: [FLINK-10724]
Refactor failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r274967719
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -954,6 +968,7 @@ public void heartbeatFromResourceManager(final ResourceID
resourceID) {
}
return checkpointCoordinator
.triggerSavepoint(System.currentTimeMillis(),
targetDirectory)
+
.thenApply(CheckpointExecuteResult::getCompletedCheckpoint)
Review comment:
If there was a savepoint failure, this call on the `CheckpointExecuteResult`
will trigger an illegal state exception and even lose the trace of the original
exception. I dont think that is what we want here, but handling two different
paths?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
