azagrebin commented on a change in pull request #8133: [FLINK-12146][network]
Remove unregister task from NetworkEnvironment to simplify the interface of
ShuffleService
URL: https://github.com/apache/flink/pull/8133#discussion_r274914550
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -879,6 +875,24 @@ else if (transitionState(current, ExecutionState.FAILED,
t)) {
}
}
+ private void releaseNetworkResources() throws Exception {
+ LOG.debug("Release task {} network resources (state: {}).",
+ taskInfo.getTaskNameWithSubtasks(),
getExecutionState());
+
+ for (ResultPartition partition : producedPartitions) {
+
taskEventDispatcher.unregisterPartition(partition.getPartitionId());
+ partition.close();
Review comment:
I guess:
```
if (isCanceledOrFailed()) {
partition.fail(getFailureCause());
} else {
partition.close();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
