xuefuz commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, 
ReadableWritableCatalog, and other …
URL: https://github.com/apache/flink/pull/8007#issuecomment-482270351
 
 
   > Sorry to jump into the discussion. I find this PR has been discussed for a 
few days and we have some divergence in the `listTables()` method name.
   > 
   > Actually, regarding to the [review 
process](https://flink.apache.org/reviewing-prs.html) (check item #2):
   > 
   > > In case of diverging opinions, the discussion should be moved to the 
respective Jira issue or to the dev mailing list and continued until consensus 
is reached.
   > 
   > I would suggest to move the discussion to the mailing list, and invite 
people who were involved in the design doc (such as @twalthr , @suez1224 ) to 
make sure we have a consensus in the community. I'm sorry if this would delay 
the merging.
   > 
   > (Although we shouldn't continue the discussion in the PR, I still leave 
some thoughts here)
   > Regarding to the naming, IMO the interface of catalog do not have to match 
SQL DDL. SQL standard doesn't define the catalog interface. So I prefer to 
separate methods for listing tables and views which is more clear to devs.
   
   @wuchong Thanks for sharing your thoughts. Agreed with you on the review 
process. Unfortunately there was a discontinuity between the design and review, 
which triggered some discussions here. On the other hand, w/o active review, 
those design discussions may never come.
   
   Nevertheless, I don't think we need to resolve every disagreement before we 
proceed. Per the listTable issue you mentioned, if we agree on the latest 
listTables() and listViews(), then we should include them in this PR while 
leaving out the controversial one (listTableWithoutViews()), for which there 
can be different solutions and it's not a show-stopper. We can come back later 
to add that when a consensus is reached.
   
   Let me know if this makes sense. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to