jonpollock edited a comment on issue #7458: [FLINK-11302] FlinkS3FileSystem 
uses an incorrect path for temporary files.
URL: https://github.com/apache/flink/pull/7458#issuecomment-481939883
 
 
   I know this is already closed and merged, but I'd just like to point out 
that the constructor of the FlinkS3FileSystem calls 
RefCountedTmpFileCreator.inDirectories, passing it a single File object. This 
method takes multiple files and each will be used as a way of spreading the 
temp files over multiple directories.
   
   The change you applied, limits this to just the first directory in the 
LOCAL_DIRS. I understand that you probably didn't want to change the 
Constructor signature, but I think that is only used in 
AbstractS3FileSystemFactory.
   
   In any case, thank you for your work and this solve a problem I've had for a 
few hours now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to