dawidwys commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#issuecomment-481752758 Hi @hequn8128, I had another look and some discussion with @twalthr about this PR and we came up with few ideas how to proceed further with this PR: 1. The `Stream/BatchTableDescriptor`, `Stream/BatchTableSource`, `Stream/BatchTableSink`, `Stream/BatchTableSourceFactory`, `Stream/BatchTableSinkFactory` should end up in the bridging module. In the long run we need to rework them anyway. The new versions will end up in the api-java. This might solve our problems with the reflection lookup for factories. 2. Could you please split the PR into smaller commits that move a smaller "hierarchies" of classes one at a time. The last commit would move just extract the TableEnvironment once all the needed classes are already moved? This would help us review this PR tremendously.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
