tillrohrmann commented on a change in pull request #8002:
[FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters
Suppliers
URL: https://github.com/apache/flink/pull/8002#discussion_r272951340
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -160,7 +149,7 @@ public MetricRegistryImpl(MetricRegistryConfiguration
config) {
}
reporters.add(reporterInstance);
- String delimiterForReporter =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,
String.valueOf(globalDelimiter));
+ String delimiterForReporter =
metricConfig.getString(ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,
String.valueOf(globalDelimiter));
Review comment:
Same here, we could have a method `MetricConfig#getReporterScopeDelimiter()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
