sunjincheng121 commented on a change in pull request #8057:
[FLINK-12028][table] Add `addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#discussion_r270821862
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java
##########
@@ -879,4 +879,117 @@
* @return An OverWindowedTable to specify the aggregations.
*/
OverWindowedTable window(OverWindow... overWindows);
+
+ /**
+ * Adds additional columns. Similar to a SQL SELECT statement. The
field expressions
+ * can contain complex expressions, but can not contain aggregations.
It will throw an exception
+ * if the added fields already exist.
+ *
+ * <p>Example:
+ * <pre>
+ * {@code
+ * tab.addColumns("a + 1 as a1, concat(b, 'sunny') as b1")
+ * }
+ * </pre>
+ */
+ Table addColumns(String fields);
+
+ /**
+ * Adds additional columns. Similar to a SQL SELECT statement. The
field expressions
+ * can contain complex expressions, but can not contain aggregations.
It will throw an exception
+ * if the added fields already exist.
+ *
+ * <p>Scala Example:
+ *
+ * <pre>
+ * {@code
+ * tab.addColumns('a + 1 as 'a1, concat('b, "sunny") as 'b1)
+ * }
+ * </pre>
+ */
+ Table addColumns(Expression... fields);
+
+ /**
+ * Adds additional columns. Similar to a SQL SELECT statement. The
field expressions
+ * can contain complex expressions, but can not contain aggregations.
Existing fields will be
+ * replaced if add columns name is the same as the existing column name.
Moreover, if the added
+ * fields have duplicate field name, then the last one is used.
+ *
+ * <p>Example:
+ * <pre>
+ * {@code
+ * tab.addOrReplaceColumns("a + 1 as a1, concat(b, 'sunny') as b1")
+ * }
+ * </pre>
+ */
+ Table addOrReplaceColumns(String fields);
+
+ /**
+ * Adds additional columns. Similar to a SQL SELECT statement. The
field expressions
+ * can contain complex expressions, but can not contain aggregations.
Existing fields will be
+ * replaced. If the added fields have duplicate field name, then the
last one is used.
Review comment:
Why we should do this change? `duplicate` -> `duplicated`? I using
`translate.google.cn`, It suggests using `duplicate`. Can you double check
this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
