zentol commented on a change in pull request #8079: [FLINK-12054][Tests]
HBaseConnectorITCase fails on Java 9
URL: https://github.com/apache/flink/pull/8079#discussion_r270426021
##########
File path:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseTestingClusterAutostarter.java
##########
@@ -211,8 +211,7 @@ private static void createHBaseSiteXml(File
hbaseSiteXmlDirectory, String zookee
private static void addDirectoryToClassPath(File directory) {
try {
- // Get the classloader actually used by
HBaseConfiguration
- ClassLoader classLoader =
HBaseConfiguration.create().getClassLoader();
Review comment:
The point of this method is to mutate the default classloader so that the
hbase-site.xml is on the classpath later on.
By creating a new classloader that is immediately discarded once the method
exists and never used to actually load anything this method becomes a no-op,
which isn't acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
