Clarkkkkk commented on a change in pull request #7780: [FLINK-11593][tests]
Check & port TaskManagerTest to new code base
URL: https://github.com/apache/flink/pull/7780#discussion_r268092357
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingAbstractInvokables.java
##########
@@ -82,4 +84,51 @@ public void invoke() throws Exception {
}
}
}
+
+ public static final class TestInvokableRecordCancel extends
AbstractInvokable {
+
+ private static final Object lock = new Object();
+ private static CompletableFuture<Boolean> gotCanceledFuture =
new CompletableFuture<>();
Review comment:
It would be easier to use a static CompletableFuture here since the object
is not initialized in the test code and it's hard to get a reference to the
CompletableFuture if it is not static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
