klion26 commented on a change in pull request #8008: [FLINK-11963][History
Server]Add time-based cleanup mechanism in history server
URL: https://github.com/apache/flink/pull/8008#discussion_r267608121
##########
File path:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
##########
@@ -123,7 +125,9 @@ void stop() {
private static final String JSON_FILE_ENDING = ".json";
- JobArchiveFetcherTask(List<HistoryServer.RefreshLocation>
refreshDirs, File webDir, CountDownLatch numFinishedPolls) {
+ JobArchiveFetcherTask(long retainedApplicationsMillis,
List<HistoryServer.RefreshLocation> refreshDirs, File webDir,
+ CountDownLatch
numFinishedPolls) {
+ this.retainedApplicationsMillis =
retainedApplicationsMillis;
Review comment:
Maybe we could add a test logic whether the passed in parameter
`retainedApplicationsMillis` is positive or not here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
