dawidwys opened a new pull request #8018: Extract logical nodes URL: https://github.com/apache/flink/pull/8018 ## What is the purpose of the change This PR brings us closer to the goal of decoupling `LogicalNodes` from planner module and moving the `TableImpl` to the `flink-table-api-java` module ## Brief change log This PR is based on top of #8017 (8c6f066 - ef55440) - 0c75ea7 - changed the `ApiExpressionVisitor` class to abstract class to make the implementation of `ApiExpressionVisitor#visit` final, otherwise it is easy to break the expected behaviour of this class by overriding the `visit` method. - 6882acc - ports the logic of splitting expressions into projections, aggregations, window properties etc. This is required to construct proper `Operation`s. The `ExpressionExtractionUtils` class do not resolve any fields. - 882159a - moved the creation of `Operation` tree to `OperationTreeBuilder`. This class is responsible for creating a resolved and validating `Operation`. In this PR it still uses the logic in `LogicalNode`, which will be further replaced. ## Verifying this change This change is already covered by existing tests in flink-table-planner-module. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
