azagrebin commented on a change in pull request #7549: [FLINK-11403][network]
Remove ResultPartitionConsumableNotifier from ResultPartition
URL: https://github.com/apache/flink/pull/7549#discussion_r266924085
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -236,21 +237,23 @@ protected ResultPartitionWriter createResultPartition(
NetworkEnvironment environment,
int channels) throws Exception {
- ResultPartition resultPartition = new ResultPartition(
+ NetworkResultPartition networkResultPartition = new
NetworkResultPartition(
"sender task",
- new NoOpTaskActions(),
- jobId,
partitionId,
ResultPartitionType.PIPELINED_BOUNDED,
channels,
1,
environment.getResultPartitionManager(),
+ ioManager);
+ environment.setupPartition(networkResultPartition);
+
+ ResultPartition resultPartition = new ResultPartition(
Review comment:
if this `resultPartition` has `NoOpTaskActions` and
`NoOpResultPartitionConsumableNotifier`, do we still need to wrap
`networkResultPartition` with it? Could we just return `networkResultPartition`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
