hequn8128 commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#issuecomment-473616641 @twalthr @sunjincheng121 I have updated the PR. Would be great if you can take another look. Some changes are explained by the followings: - To make `ExpressionParser.parseExpression()` available, the `ExpressionParser` contains two static methods: `parseExpression()` and `parseExpressionList()`. - As static methods cannot be overridden, I added a `PlannerExpressionParser` interface. The `PlannerExpressionParser` contains two non-static expression parser methods and are overridden by `PlannerExpressionParserImpl`. So once we get a `PlannerExpressionParserImpl` instance through refection, we can call parseExpression() in `PlannerExpressionParserImpl`. - Furthermore, I add a companion class `PlannerExpressionParserImpl`. This is because we can't new object directly. - Both `ExpressionParser` and `PlannerExpressionParser` in api-java are marked as Internal class. Best, Hequn
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
