pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#discussion_r265982238
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java ########## @@ -118,13 +117,19 @@ protected Throwable getFailureCause() { /** * Gets the number of non-event buffers in this subpartition. - * - * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access - * scenarios since it does not make any concurrency guarantees. */ - @VisibleForTesting - public int getBuffersInBacklog() { - return buffersInBacklog; + public abstract int getBuffersInBacklog(); + + /** + * @param lastBufferAvailable whether the last buffer in this subpartition is available for consumption + * @return the number of non-event buffers in this subpartition + */ + protected int getBuffersInBacklog(boolean lastBufferAvailable) { Review comment: I get your point, however the two usages of this method below showed that it's confusing as it is now. > Anyway I am willing to make it Unsafe here, then we could avoid explaining it in method comments. Making code self explanatory is definitely a good thing :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services