pnowojski commented on a change in pull request #7959: [FLINK-11876] Introduce new TwoInputSelectable, BoundedOneInput and BoundedTwoInput interfaces URL: https://github.com/apache/flink/pull/7959#discussion_r265971160
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InputIdentifier.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.operators; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * The identifier for the input(s) of the operator. It is numbered starting from 1, and + * 1 indicates the first input. With one exception, -1 indicates all inputs. + */ +@PublicEvolving +public final class InputIdentifier { + + /** + * The {@code InputIdentifier} object corresponding to the input id {@code -1}. + */ + public static final InputIdentifier ALL = new InputIdentifier(-1); + + /** + * The {@code InputIdentifier} object corresponding to the input id {@code 1}. + */ + public static final InputIdentifier FIRST = new InputIdentifier(1); + + /** + * The {@code InputIdentifier} object corresponding to the input id {@code 2}. + */ + public static final InputIdentifier SECOND = new InputIdentifier(2); + + private final int inputId; + + private InputIdentifier(int inputId) { Review comment: Maybe a little bit, but this is not a single input identifier. This is bitmask with possible selection of multiple inputs, so the current name is definitely miss-leading. You even could potentially call `operator.endInput(InputSelection.ALL)`. However we might we can come up with a better name then `InputSelection`? `InputSet`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
