sunjincheng121 commented on a change in pull request #7985: [FLINK-11918][table] Deprecated Window and Rename it to GroupWindow URL: https://github.com/apache/flink/pull/7985#discussion_r265860587
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/WindowHelper.scala ########## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.api + +import org.apache.flink.table.expressions.{Expression, ExpressionParser} + +/** + * Base class for Tumble Window Helper classes. This class contains help methods to create Tumble + * Windows. + */ +trait TumbleBase { Review comment: I think we do not need create a new class `WindowHelper` all those defined can be placed into `winodws.scala` What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
