zhijiangW commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r265627063
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java ########## @@ -21,30 +21,30 @@ import org.apache.flink.core.io.IOReadableWritable; Review comment: I guess you meant the third commit in this PR? I should explain the differences for these commits. The second commit adds one whole test for `BroadcastRecordWriter`. The third commit is just making the previous tests in `RecordWriterTest` work in the way of `BroadcastRecordWriter`. So it is a refactor work. Before refactor, all the tests would create `SelectorRecordWriter` instance when running in `BroadcastRecordWriterTest` . After refactor, we defined the `isBroadcastWriter` for creating `BroadcastRecordWriter` instance when running these tests in `BroadcastRecordWriterTest`. It could be squashed with the second commit. But I thought it would be clear for review separately. The fourth commit is for simplifying the previous codes, actually it is not related to this PR. We could also submit a separate PR for it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
