klion26 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add
customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r265436293
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -468,6 +470,8 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
flinkConfiguration.setString(dynProperty.getKey(),
dynProperty.getValue());
}
+ this.flinkVersion = dynProperties.getOrDefault("flink-version",
"");
Review comment:
Whether we could get the version from the properties already in this class,
like `flinkJarPath`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
