sunjincheng121 commented on a change in pull request #7976: [FLINK-11908] Port window classes into flink-api-java URL: https://github.com/apache/flink/pull/7976#discussion_r265415615
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/GroupWindow.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.api; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * A group window specification. + * + * <p>Group windows group rows based on time or row-count intervals and is therefore essentially a + * special type of groupBy. Just like groupBy, group windows allow to compute aggregates + * on groups of elements. + * + * <p>Infinite streaming tables can only be grouped into time or row intervals. Hence window + * grouping is required to apply aggregations on streaming tables. + * + * <p>For finite batch tables, group windows provide shortcuts for time-based groupBy. + * + * <p>Note: {@link Window} is temporally used as the father class of {@link GroupWindow} for the + * sake of compatibility. It will be removed later. Review comment: Here just a suggestion, how about we open a new PR for Deprecated the Window in release-1.8, since we should create a new RC2 for release 1.8. If we do not do that the Window will keep existing for almost half a year. And I'll create the Jira FLINK-11918, and link to release-1.8 vote mail thread, ask RM's options. If all of you do not agree, I'll close the JIRA, otherwise, we can open the new PR for Deprecated the window. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
