JingsongLi commented on issue #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#issuecomment-472320682 > Thanks for working on this, besides from some comments i already left, here is another question: how many extra work will be introduced if we don't add `TypeComparator` to internal data structures like `BinaryString` and `Decimal` Thanks review, We use code gen now, TypeComparator is not useful, I will delete them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
