[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718393#comment-14718393
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38192065
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/RemoteExecutorHostnameResolutionTest.java
---
@@ -88,15 +65,14 @@ private static void checkPreconditions() {
// the test can only work if the invalid URL cannot be resolves
// some internet providers resolve unresolvable URLs to
navigational aid servers,
// voiding this test.
- boolean throwsException;
try {
//noinspection ResultOfMethodCallIgnored
InetAddress.getByName(nonExistingHostname);
- throwsException = false;
}
catch (UnknownHostException e) {
- throwsException = true;
+ return;
}
- assumeTrue(throwsException);
+
+ fail("Expected UnknownHostException but none was thrown.");
--- End diff --
Matter of taste. I change it. I don't care.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
