KurtYoung commented on a change in pull request #7817: [FLINK-11702][table-planner-blink] Introduce a new table type system: InternalType URL: https://github.com/apache/flink/pull/7817#discussion_r261071464
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/type/InternalTypes.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.type; + +import org.apache.flink.api.common.typeinfo.TypeInformation; + +/** + * Accessor of {@link InternalType}s. + */ +public class InternalTypes { + + public static final StringType STRING = StringType.INSTANCE; + + public static final BooleanType BOOLEAN = BooleanType.INSTANCE; + + public static final DoubleType DOUBLE = DoubleType.INSTANCE; + + public static final FloatType FLOAT = FloatType.INSTANCE; + + public static final ByteType BYTE = ByteType.INSTANCE; + + public static final IntType INT = IntType.INSTANCE; + + public static final LongType LONG = LongType.INSTANCE; + + public static final ShortType SHORT = ShortType.INSTANCE; + + public static final CharType CHAR = CharType.INSTANCE; + + public static final BinaryType BINARY = BinaryType.INSTANCE; + + public static final DateType DATE = DateType.INSTANCE; + + public static final TimestampType TIMESTAMP = TimestampType.INSTANCE; + + public static final TimeType TIME = TimeType.INSTANCE; + + public static final DecimalType SYSTEM_DEFAULT_DECIMAL = DecimalType.SYSTEM_DEFAULT; + + public static ArrayType createArrayType(InternalType elementType) { + return new ArrayType(elementType, false); Review comment: Same question to the `false` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
