zhijiangW commented on a change in pull request #7631: [FLINK-11391][shuffle]
Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor
URL: https://github.com/apache/flink/pull/7631#discussion_r260668512
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
##########
@@ -52,30 +52,38 @@
/** The ID of the partition the input channel is going to consume. */
private final ResultPartitionID consumedPartitionId;
- /** The location of the partition the input channel is going to
consume. */
- private final ResultPartitionLocation consumedPartitionLocation;
+ /** The location type of the partition the input channel is going to
consume. */
+ private final LocationType locationType;
+
+ /** The connection to use to request the remote partition. */
+ private final Optional<ConnectionID> connectionId;
Review comment:
Considering the point 1, I think ICDD might include [`SDD`,
`ResultPartitionID`, `consumerResourceID`].
The `PartitionInfo` might be replaced by `ICDD` directly because the current
only different field `IntermediateDataSetID` is only used for finding the
proper `SingleInputGate` during `updatePartitionInfo` in task. Then we can use
the `ResultPartitionID` in ICDD to find the proper `SingleInputGate` instead. I
want to refactor this process to remove `PartitionInfo` first in a separate PR.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
