Clarkkkkk commented on a change in pull request #7780: [FLINK-11593][tests] 
Check & port TaskManagerTest to new code base
URL: https://github.com/apache/flink/pull/7780#discussion_r261062837
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ##########
 @@ -1413,7 +1413,8 @@ public ResourceID getResourceID() {
         *
         * @param t The exception describing the fatal error
         */
-       void onFatalError(final Throwable t) {
+       @VisibleForTesting
+       public void onFatalError(final Throwable t) {
 
 Review comment:
   @TisonKun The method is used in 
TaskExecutorTests.testTerminationOnFatalError().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to