klion26 commented on a change in pull request #7726: [FLINK-10342] Filter 
restored partitions with discovered partitions b…
URL: https://github.com/apache/flink/pull/7726#discussion_r260539665
 
 

 ##########
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ##########
 @@ -515,15 +510,17 @@ public void open(Configuration configuration) throws 
Exception {
                        }
 
                        if (filterRestoredPartitionsWithDiscovered) {
-                               
subscribedPartitionsToStartOffsets.entrySet().removeIf(
-                                       entry -> {
-                                               if 
(!allPartitions.contains(entry.getKey())) {
-                                                       LOG.warn("{} is removed 
from subscribed Partitions.", entry.getKey());
-                                                       return true;
-                                               }
-                                               return false;
+                               Iterator<Map.Entry<KafkaTopicPartition, Long>> 
iter = subscribedPartitionsToStartOffsets.entrySet().iterator();
 
 Review comment:
   @fengli If you just want to check the style, you could use `mvn clean 
validate -Denforcer.skip -T 1C -nsu`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to