walterddr commented on issue #7607: [FLINK-10076][table] Upgrade Calcite dependency to 1.18 URL: https://github.com/apache/flink/pull/7607#issuecomment-466559861 Thanks @twalthr for the feedback. I will change the inline comments accordingly. Regarding the dependency changes. I wasn't sure if I was configuring incorrectly or what. somehow I cannot make the tests go through as travis picked up the guava version 16 included in the flink-runtime (via. flink-shaded-curator), and calcite now uses some classes only exists in calcite 19. Regarding the json / jackson dependencies. one of the additions in calcite 18 was the json support and thus these 2 are hard dependencies we cannot avoid. I think the question remains, where should we put these in the pom file. Is there special suggestions in this as I am pretty new to dependency management on apache projects. any feedback and suggestions are very welcome and appreciated
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
